Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branchprotector failing to remove required status for removed jobs #345

Closed
Tracked by #297
BenTheElder opened this issue Dec 16, 2024 · 4 comments
Closed
Tracked by #297
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. sig/testing Categorizes an issue or PR as relevant to SIG Testing.

Comments

@BenTheElder
Copy link
Member

see also: kubernetes/test-infra#33900 with prior discussion

note: it is no longer failing on timeout, but it is still failing, the logs don't seem super helpful and it's not removing required checks that are no longer necessary

seems bugged?

/help

@k8s-ci-robot
Copy link
Contributor

@BenTheElder:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

see also: kubernetes/test-infra#33900 with prior discussion

note: it is no longer failing on timeout, but it is still failing, the logs don't seem super helpful and it's not removing required checks that are no longer necessary

seems bugged?

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Dec 16, 2024
@BenTheElder
Copy link
Member Author

/kind bug
/sig testing

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 16, 2024
@BenTheElder
Copy link
Member Author

ok, so at least some of this was needing repo:public_repo scope on the PAT ...

but we're still having issues kubernetes/test-infra#33900 (comment)

@BenTheElder
Copy link
Member Author

this aspect is resolved. TBD on the gh-pages branches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Development

No branches or pull requests

2 participants