-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make pod_name and pod_namespace optional #39
Comments
actually those need to be passed as parameters node-ipam-controller/pkg/leaderelection/leaderelection.go Lines 16 to 22 in 0a1e0fd
you can use some defaults , for namespace "default, and for id is commont to use os.Hostname() |
The biggest problem at the moment that they are not specified and by default the controller runs in leader election mode, but without these variables it fails to start. Would be nice to address it |
yeah, we can define some default values , pod_name = os.Hostname() and pod_namespace = "default" or "kube-system", whatever we use to install our controller, I can not remember now |
maybe also can be used staging/src/k8s.io/component-helpers/node/util/hostname.go:28 |
yeah, that works too |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
Currently, POD_NAME and POD_NAMESPACE environment variables are mandatory. As a user I don't want to specify them but just run the controller.
Investigate if
Update readme with both variables, descriptions and default values from the investigation.
The text was updated successfully, but these errors were encountered: