Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate use of health checks adapter in LeaderElection #26

Open
ugur99 opened this issue Jul 31, 2024 · 3 comments
Open

Investigate use of health checks adapter in LeaderElection #26

ugur99 opened this issue Jul 31, 2024 · 3 comments
Assignees
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@ugur99
Copy link
Contributor

ugur99 commented Jul 31, 2024

LeaderElection has an option to specify a health checks adapter. We may need to consider investigating whether this adapter can be useful.

See: #20

@Peac36
Copy link
Contributor

Peac36 commented Aug 25, 2024

/assign

@Peac36
Copy link
Contributor

Peac36 commented Sep 26, 2024

Hey @mneverov - I did some research on the leader elector health checker. It was introduced as a workaround of the following issue - kubernetes/kubernetes#70819
The issue stems from golang.org/x/net/ library that had a deadlock. To mitigate the issue the health checker was introduced so the deadlock could be detected.

However, the real fix of the issue was introduced with golang 1.11 where the deadlock was removed - golang/net@6a8eb5e

Since we are already on the golang 1.20 I don't reason to implement this.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

4 participants