Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination size cmd line arg #1998

Open
ivelichkovich opened this issue Jan 2, 2025 · 6 comments
Open

Pagination size cmd line arg #1998

ivelichkovich opened this issue Jan 2, 2025 · 6 comments
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@ivelichkovich
Copy link

ivelichkovich commented Jan 2, 2025

What would you like to be added:

configurable pagination for nfd-gc list request via command line arg

configurable pagination for nfd-master informer sync initial list via command line arg

related to this: #1815

Why is this needed:

more control over request behavior to api-server

@ivelichkovich ivelichkovich added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 2, 2025
@ivelichkovich
Copy link
Author

/assign ivelichkovich

@marquiz
Copy link
Contributor

marquiz commented Jan 3, 2025

Thanks @ivelichkovich for the request. Makes sense to me. Simplest solution would be to add a config file option
/help

@k8s-ci-robot
Copy link
Contributor

@marquiz:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

Thanks @ivelichkovich for the request. Makes sense to me. Simplest solution would be to add a config file option
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jan 3, 2025
@ivelichkovich
Copy link
Author

I'm happy to work on this :)

@ivelichkovich
Copy link
Author

Will raise an MR soon

@ivelichkovich
Copy link
Author

so I was actually thinking the MR I linked was adding pagination to nfd-master for its informer cache so I raised an MR adding configurable pagination to the NFD master: #2000

and then here's the MR for configurable pagination to NFD GC: #2001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants