The committers listed above are authorized under a signed CLA.

• ✅ login: AllenXu93 (5d40f79, a694d91, f740e1d, 17d374d)

Welcome @AllenXu93!

It looks like this is your first PR to kubernetes-sigs/node-feature-discovery 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/node-feature-discovery has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

Hi @AllenXu93. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name	Link
🔨 Latest commit	5d40f79
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/677e83c51b23730008b1ea08
😎 Deploy Preview	https://deploy-preview-1979--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

/cc

Need to review the code before to comment :)
While I get again up to speed, do we have test coverage for this change? can we use more unit/e2e tests?

/ok-to-test

While I get again up to speed, do we have test coverage for this change? can we use more unit/e2e tests?

We seem to have some as the tests failed. But yes, we should have specific test case for this scenario-

@AllenXu93 could you fix and update the tests?

While I get again up to speed, do we have test coverage for this change? can we use more unit/e2e tests?

We seem to have some as the tests failed. But yes, we should have specific test case for this scenario-

@AllenXu93 could you fix and update the tests?

ok I will fix in this week

/test pull-node-feature-discovery-build-image-cross-generic

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AllenXu93
Once this PR has been reviewed and has the lgtm label, please assign marquiz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Now the unit tests fail