Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose E/P core information though ResourceAggregator #1964

Open
ozhuraki opened this issue Nov 29, 2024 · 5 comments
Open

Expose E/P core information though ResourceAggregator #1964

ozhuraki opened this issue Nov 29, 2024 · 5 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@ozhuraki
Copy link
Contributor

Modify ResourceAggregator to advertise new resources for each cpu type in each Zone (NUMA node) by mapping generic k8s cpu resource to each cpu_type.

@ozhuraki ozhuraki added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 29, 2024
@ffromani
Copy link
Contributor

/cc

@ffromani
Copy link
Contributor

Hi! I'm not clear about the requirement. Do you want to

  • just advertise there are E cores and P cores (aka not all CPUs are equal?)
  • advertise how many E core and P core are allocated/available (aka split the cpu resource)?
  • anything else?

cc @PiotrProkop @marquiz @kad

@ozhuraki
Copy link
Contributor Author

@ffromani @PiotrProkop

just advertise there are E cores and P cores (aka not all CPUs are equal?)

In a simplest case, yes. This is already in #1737

advertise how many E core and P core are allocated/available (aka split the cpu resource)?

In principle, this is already in #1737 too (we expose core IDs for each core type)

anything else?

If I understood @PiotrProkop thought to add this information to NRT object in order advertise new resources for each cpu type in each Zone (NUMA node) by mapping generic k8s cpu resource to each cpu_type.

@kad
Copy link
Contributor

kad commented Dec 16, 2024

Initial requirement was for out-of-tree components to get information about node, to know which cpu number is which type.
Those CPU types are usually single sockets, so it is not really mapped to "NUMA" node.
For just marking the node, we had boolean label "node has hybrid cpu cores". So, that mentioned initial request was about exposing a bit more details over nfd.

@ffromani
Copy link
Contributor

I see the value in exposing this information, it fits in the "export more detailed topology information than the default k8s resource model" that nfd-topology-updater is alla about.
I think that this is a good option to leverage and make good use of the great flexibility the API grants. Rather than shoehorning the values as attributes, or moving them in the existing NUMA zone reporting (IIUC this is a poor fit), I'd explore the option to add completely new zones describing the E/P split and count.
After all, we designed the API to allow this form of flexibility from day 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants