Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

labels stay on nodes after I deleted the all plain NFD manifests #1896

Open
jz543fm opened this issue Oct 2, 2024 · 3 comments
Open

labels stay on nodes after I deleted the all plain NFD manifests #1896

jz543fm opened this issue Oct 2, 2024 · 3 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@jz543fm
Copy link

jz543fm commented Oct 2, 2024

I've tried to apply by doc NFD manifest with kubectl apply -k '<url>', but when I tried to use kubectl delete -k '<url>' for the removing deployment of NFD, labels that are generated with NFD deployments are deleted after kubectl delete -k '' , when I've downloaded plain manifests and I am tryning to deploy (I've get all manifests with the kubectl.... -o yaml option ), deploy works, adds labels but when I tried the kubectl delete -f <manifests_folder> it can not remove labels from nodes, but when I try to delete it with kubectl delete -k '<url>' that works and removes labels

@jz543fm jz543fm changed the title labels stay on nodes after I deleted the all manifests labels stay on nodes after I deleted the all plain NFD manifests Oct 2, 2024
@jz543fm
Copy link
Author

jz543fm commented Oct 3, 2024

It looks like the daemonset.apps/nfd-worker created should be deleted first, when I try to delete the all manifest with kubectl delete -f dir/ it deletes all manifests but labels stays, when I tried to delete the daemonset nfd-worker first, it deletes the labels

@marquiz
Copy link
Contributor

marquiz commented Oct 9, 2024

Unfortunately there is not enough detailed control of (un)deployment of objects with kustomize.

If you want to cleanup the nodes, see https://kubernetes-sigs.github.io/node-feature-discovery/v0.16/deployment/uninstallation.html

Another solution is to manually delete the nfd-worker daemonset manually (like you did), wait for all nodes to be updated and then do kubectl delete -k that will remove the other stuff.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

4 participants