Improved liveness probe for nfd-master

[marquiz]

What would you like to be added:

The implementation of the gRPC health server in nfd-master is very simple and naive, in practice only telling that the nfd-master main loop was started and that the program hasn't exited. This could be improved e.g. by including the state of the metrics server, nfd api controller and node updater pool (i.e. healthcheck fails if any of those goes down).

Why is this needed:

More trust on the liveness data.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle rotten
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[marquiz]

/remove-lifecycle rotten

[omerap12]

Hey @marquiz , maybe I can assist with it :)

[omerap12]

/assign

[marquiz]

Hey @marquiz , maybe I can assist with it :)

Wow, appreciated

[omerap12]

Hey @marquiz , maybe I can assist with it :)

Wow, appreciated

sure why not, seems like a task I can take ( but I may ask a few questions along the way if that's ok )

[marquiz]

I may ask a few questions along the way if that's ok

Definitely. The "design" details in the description are pretty vague and really hastily written

[omerap12]

Hi @marquiz, I've started working on issue #1814. Could you take a quick look and let me know if I'm on the right track?

[omerap12]

friendly remainder :) @marquiz

[marquiz]

friendly remainder :) @marquiz

Thanks @omerap12. I try to find a peaceful slot tomorrow to look at that

[omerap12]

friendly remainder :) @marquiz

Thanks @omerap12. I try to find a peaceful slot tomorrow to look at that

Sure, it's just a quick sketch, and I wanted to check if I'm addressing this in a sensible manner. Thanks!

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[TessaIO]

/remove-lifecycle stale