Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal nr.2: Support for custom index repositories #483

Closed
chriskim06 opened this issue Jan 30, 2020 · 15 comments
Closed

Proposal nr.2: Support for custom index repositories #483

chriskim06 opened this issue Jan 30, 2020 · 15 comments
Assignees
Labels
area/multi-index kind/proposal lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@chriskim06
Copy link
Member

Allowing users to specify custom indices to download plugins from would allow people to distribute plugins without having to go through the main krew-index repo. This would be useful at companies where people want to share plugins that are specific to their workflows or aren't appropriate for krew-index.

I wanted to share the proposal doc I had thrown together here https://docs.google.com/document/d/1Im5gmBA6yuKRWgJWbaBjTTFNvkH0me05V3wEeNPU7fE/edit?usp=sharing and opened a new issue for it based on this. There's a lot of similarities to the docs in #23 so if this doesn't add enough I'd be happy to close this.

A lot of ideas came from https://docs.brew.sh/Taps, mainly around how to handle duplicate plugin names.

@ahmetb ahmetb changed the title Proposal: custom indices Proposal #1: Support for custom index repositories Jan 30, 2020
@ahmetb ahmetb changed the title Proposal #1: Support for custom index repositories Proposal nr.2: Support for custom index repositories Jan 30, 2020
@ahmetb
Copy link
Member

ahmetb commented Jan 30, 2020

Thanks for writing this up.
I'm calling this "proposal number two" for index repos, as you've said there are similarities.
I think both Cornelius and I should read both how Taps work and how your design works. It might take some time but hang in there.
/kind proposal

@ahmetb
Copy link
Member

ahmetb commented Feb 8, 2020

/assign

@corneliusweig
Copy link
Contributor

@chriskim06 can you ping me on kubernetes slack?

@ahmetb
Copy link
Member

ahmetb commented Feb 12, 2020

Ahead of our online meeting about this on Feb 18th, I've documented my wishlist of what I'd love to see from the solution + implementation process:

https://docs.google.com/document/d/1_xYsxtwtQTboKOyp920pb1OWLTQEdU6gF7-QvUA6S0Y/edit?usp=sharing

@chriskim06
Copy link
Member Author

Sounds good I'll take a look through that doc and add comments if I have any questions

@ahmetb
Copy link
Member

ahmetb commented Feb 20, 2020

Both @corneliusweig and @ahmetb (myself) have discussed the proposal with @chriskim06 and approved it.

@jdolitsky
Copy link

Late to the game here, but would like to point to #580 regarding alternative approach to distribution via OCI

@jdolitsky
Copy link

The fact that this issue has come up is actually itself testament to "why use OCI" - all these concepts (multitenancy, distributed repos, auth) have already been solved for in the context of Docker push/pull which is the basis for OCI distribution-spec: https://github.com/opencontainers/distribution-spec

@jdolitsky
Copy link

and yes, I realize this throws a big wrench into the existing plan and architecture, but I feel very strongly this is the correct way forward, especially for tooling in the k8s/container space. feel free to reach out to discuss more.

@ahmetb
Copy link
Member

ahmetb commented Apr 1, 2020

@jdolitsky let's move the discussion there as it doesn't concern this feature.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 30, 2020
@ahmetb
Copy link
Member

ahmetb commented Jun 30, 2020

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 30, 2020
@chriskim06
Copy link
Member Author

Should we close this one too?

@ahmetb
Copy link
Member

ahmetb commented Aug 28, 2020

👍🏼
/close

@k8s-ci-robot
Copy link
Contributor

@ahmetb: Closing this issue.

In response to this:

👍🏼
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/multi-index kind/proposal lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

6 participants