Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter InferenceModels from Reconciliation #149

Open
danehans opened this issue Jan 6, 2025 · 2 comments
Open

Filter InferenceModels from Reconciliation #149

danehans opened this issue Jan 6, 2025 · 2 comments
Assignees

Comments

@danehans
Copy link
Contributor

danehans commented Jan 6, 2025

Currently, the InferenceModel reconciler reconciles all InferenceModels in the configured namespace. Since the endpoint picker extension is configured for a single InferencePool name, the InferenceModel reconciler should only reconcile InferenceModels that reference, e.g. poolRef, the configured InferencePool.

InferenceModels that do not reference the configured InferencePool are deleted from the data store. Why is this approach being taken instead of filtering the watch, e.g Predicate, so the reconciler only reconciles matching InferenceModels?

@danehans
Copy link
Contributor Author

danehans commented Jan 6, 2025

/assign

@liu-cong
Copy link
Contributor

liu-cong commented Jan 6, 2025

@kfswain may have some insights. It looks to me either approach should work?

I have another point about filtering InferenceModels in the same namespace as the InferencePool. In my opinion users should be allowed to create InferenceModels in different namespaces (think a team owns its own model and namespace). cc @ahg-g and @robscott

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants