-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add helm-unittest to enchance helm behaviour #4989
Comments
Hi @stevehipwell. My understanding this is your area. What do you think? |
Hi @ivankatliarchuk Helm chart unit tests can add value but I think before adding any we'd want to do a cost/benefit analysis. IMHO the first thing to look at for improving the quality of a chart is the JSON schema, this should catch the majority of the misconfiguration issues. Once a chart has a full schema then anything not covered by that could be considered a target for a unit test. |
Ok. Let me know when cost/benefit analysis is conducted. So I open a pr or close this issue)) The Helm JSON schema validates the format and correctness of the values provided to the chart. Helm unit tests go further by verifying the chart's functionality, including the accurate generation of templates based on different sets of values. Sort of different problems. But yes, having Json Schema will simplify some of the things, and we could have some automated documentation generated as well. |
@ivankatliarchuk without a full JSON schema I don't think there is enough benefit to work on this. That said I'm happy for someone to take a real world problem and if it's still an issue after the values are fully covered by a JSON schema, I'd be happy to review unit tests as a solution. |
What would you like to be added:
Add
helm-unittest
as github action to test helm chartTool https://github.com/helm-unittest/helm-unittest
I can share more examples
Why is this needed:
There are quite few helm issues, the helm-unittest could help a bit. As having tests will resolve some regression and we could validate behaviour when different values supplied.
The text was updated successfully, but these errors were encountered: