Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Able to set Debug option for each HelmChartProxy individually #317

Open
dmvolod opened this issue Nov 27, 2024 · 4 comments
Open

Able to set Debug option for each HelmChartProxy individually #317

dmvolod opened this issue Nov 27, 2024 · 4 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@dmvolod
Copy link
Contributor

dmvolod commented Nov 27, 2024

User Story
Right now, debug option can be enabling for whole controller and components centrally as running flag. And it's not possible to setup it for each HelmChartProxy, but in some cases, whole controller reconfiguration are not allowing.

As a user, I would like to enable debug option for each HelmChartProxy individually like a helm cli command, i.e.

helm install -f myvalues.yaml myredis ./redis --debug

Detailed Description
For this case, I suggesting to create an optional Debug (bool) field inside the HelmOptions API struct, propagate it into the HelmInit method and set log level to 2 (default) if this option is enabled.

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 27, 2024
@Jont828
Copy link
Contributor

Jont828 commented Dec 4, 2024

/triage-accepted

Will take a look on Thurs.

@dmvolod
Copy link
Contributor Author

dmvolod commented Dec 4, 2024

Thanks for accepting, @Jont828
Was planning to fix it soon

@dmvolod
Copy link
Contributor Author

dmvolod commented Dec 4, 2024

/assign

@Jont828
Copy link
Contributor

Jont828 commented Dec 5, 2024

I took a closer look at your issue, and I think passing the --debug flag in to helm install or helm upgrade for an individual HelmChartProxy instance makes sense. Only thing is that I'm not sure if we can set the log level on the CRD level, since that gets set by the controller args for the whole container when the caaph-controller-manager pod gets created, not on each reconciliation loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants