Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating keyed/skruv failed #1799

Closed
krausest opened this issue Dec 14, 2024 · 0 comments · Fixed by #1807
Closed

Updating keyed/skruv failed #1799

krausest opened this issue Dec 14, 2024 · 0 comments · Fixed by #1807

Comments

@krausest
Copy link
Owner

As in #1789 I'm updating all implementations. Implementations that failed to update are moved in to the broken-frameworks folder.
Here's what I'm trying to update:

 esbuild  ^0.18.13  →  ^0.24.0
 skruv       0.6.3  →    0.7.3

The build fails with the following build error:

Executing frameworks/keyed/skruv and benchmark 06_remove-one-1k failed: checkElementContainsText tbody>tr:nth-of-type(6)>td:nth-of-type(1) failed. expected 12, but was 11

Manually clicking on the remove button is causing strange behaviour (2nd click doesn't remove the row).
@SvanteRichter Can you take a look at this?
krausest added a commit that referenced this issue Dec 14, 2024
@krausest
Updating keyed/skruv failed #1799
c733e90
SvanteRichter added a commit to SvanteRichter/js-framework-benchmark that referenced this issue Dec 16, 2024
@SvanteRichter
Revert "Updating keyed/skruv failed krausest#1799"
650dfed 
This reverts commit c733e90.
@SvanteRichter SvanteRichter mentioned this issue Dec 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update skruv SvanteRichter/js-framework-benchmark
1 participant
@krausest