Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating keyed/million failed #1798

Open
krausest opened this issue Dec 14, 2024 · 0 comments
Open

Updating keyed/million failed #1798

krausest opened this issue Dec 14, 2024 · 0 comments

Comments

@krausest
Copy link
Owner

As in #1789 I'm updating all implementations. Implementations that failed to update are moved in to the broken-frameworks folder.
Here's what I'm trying to update:

-    "million": "2.3.3",
+    "million": "3.1.11",

The build fails with the following build error:

[!] RollupError: Unexpected token (Note that you need plugins to import files that are not JavaScript)
src/main.jsx (88:2)
86: 
87: const Main = block(({ rows }) => (
88:   <div class="container">
      ^
89:     <div class="jumbotron">
90:       <div class="row">
    at error (/home/stefan/js-framework-benchmark/frameworks/keyed/million/node_modules/rollup/dist/shared/rollup.js:353:30)
    at Module.error (/home/stefan/js-framework-benchmark/frameworks/keyed/million/node_modules/rollup/dist/shared/rollup.js:15237:16)
    at Module.tryParse (/home/stefan/js-framework-benchmark/frameworks/keyed/million/node_modules/rollup/dist/shared/rollup.js:15968:25)
    at Module.setSource (/home/stefan/js-framework-benchmark/frameworks/keyed/million/node_modules/rollup/dist/shared/rollup.js:15569:39)
    at ModuleLoader.addModuleSource (/home/stefan/js-framework-benchmark/frameworks/keyed/million/node_modules/rollup/dist/shared/rollup.js:25804:20)

@aidenybai Can you take a look at this?

krausest added a commit that referenced this issue Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant