FIX: ScriptInvocationManager data race

koying · Dec 22, 2016 · ca693de · ca693de
1 parent cc3027a
commit ca693de
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/xbmc/interfaces/generic/ScriptInvocationManager.cpp b/xbmc/interfaces/generic/ScriptInvocationManager.cpp
@@ -235,11 +235,12 @@ int CScriptInvocationManager::ExecuteAsync(const std::string &script, LanguageIn
 
   CSingleLock lock(m_critSection);
   invokerThread->SetId(m_nextId++);
-  lock.Leave();
 
   LanguageInvokerThread thread = { invokerThread, script, false };
   m_scripts.insert(std::make_pair(invokerThread->GetId(), thread));
   m_scriptPaths.insert(std::make_pair(script, invokerThread->GetId()));
+  lock.Leave();
+
   invokerThread->Execute(script, arguments);
 
   return invokerThread->GetId();