Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash safety #12

Open
divergentdave opened this issue Jul 29, 2023 · 0 comments
Open

Crash safety #12

divergentdave opened this issue Jul 29, 2023 · 0 comments

Comments

@divergentdave
Copy link

I ran a stripped down version of my ALICE test harness against a recent alpha of sled, and identified some durability issues. Half of the reported items were low hanging fruit in marble's creation of a new object store. (These could also mask more subtle issues after startup) See also spacejam/sled#1229.

  • The base directory should be fsynced (if on Linux) after creating the slabs and metadata subdirectories.
  • The metadata directory should be fsynced after creating a new log file. It is already fsynced immediately before this, and following installation of a new snapshot via a rename.
  • The slabs directory should be fsynced after creating all slab files.
  • It appears that slab files are not fdatasync'd after appending to them, and this breaks the durability of sled's flush.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant