Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some translation keys possibly not read #129

Open
weidengeist opened this issue Oct 21, 2022 · 7 comments
Open

Some translation keys possibly not read #129

weidengeist opened this issue Oct 21, 2022 · 7 comments

Comments

@weidengeist
Copy link
Contributor

weidengeist commented Oct 21, 2022

Hi @spajus,

I have noticed three keys in the translation files that are not used although they are present: comfortable.work.spot, slept.in.unfamiliar.bed, and socialized.with. The game uses the English terms instead.

Regards,
Weidengeist

@Ciizel
Copy link
Contributor

Ciizel commented Oct 22, 2022

Same problem with nav.fail.being.immobilized

2022-10-22 13 14 22

@spajus
Copy link
Member

spajus commented Oct 22, 2022

@weidengeist how did you figure those keys are not used? slept.in.unfamiliar.bed is surely used as a mood effect label, checked in code just now. All of these should be used, and all of them are mood effects. You can find them in game if you click on colonist, then on mood in top-left ui.

@weidengeist
Copy link
Contributor Author

@spajus I saw it just yesterday in a stream on Twitch. The player had the most recent version and showed the current changelog in the beginning.
screenshot10-22-12:01:16_annotated

@weidengeist
Copy link
Contributor Author

weidengeist commented Oct 22, 2022

I have just taken a look into one of my own games and at least for socialized.with I can say that it is translated correctly. I will keep an eye out for the other keys mentioned above.

Could it be related to the Twitch streamer’s save file that it is not translated?

Edit: Can confirm slept.in.unfamiliar.bed now as well. Translated as expected.

@spajus
Copy link
Member

spajus commented Oct 23, 2022

Yes, it is definitely going to be the save file keeping previous mood effect title. Translations are often cached in game state, since there would be a performance penalty to always translate everything.

@weidengeist
Copy link
Contributor Author

Thank you very much for your answer. I will tell the Twitch streamer about that. I don’t consider it an issue that has to be resolved, because it will not matter in the final version when new games are created and the translations are complete.

@spajus
Copy link
Member

spajus commented Oct 23, 2022

There is a "clear history" button in the colonist mood list, that will keep only currently happening events, and those old translations will be wiped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants