Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCIA_Image_Visualization_with_itkWidgets.ipynb #30

Closed
kirbyju opened this issue Sep 24, 2024 · 5 comments
Closed

TCIA_Image_Visualization_with_itkWidgets.ipynb #30

kirbyju opened this issue Sep 24, 2024 · 5 comments

Comments

@kirbyju
Copy link
Owner

kirbyju commented Sep 24, 2024

Hi @thewtex @bnmajor ,

In https://github.com/kirbyju/TCIA_Notebooks/blob/main/TCIA_Image_Visualization_with_itkWidgets.ipynb, once reaching this step in Google Colab:

from itkwidgets import view

The following error occurs:

---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
[<ipython-input-10-7ede38f9bd2c>](https://localhost:8080/#) in <cell line: 4>()
      2 #   The view() function opens an interactive viewer for 2D and 3D
      3 #   data in a variety of formats.
----> 4 from itkwidgets import view

4 frames
[/usr/local/lib/python3.10/dist-packages/ngff_zarr/from_ngff_zarr.py](https://localhost:8080/#) in <module>
      5 import dask.array
      6 import zarr
----> 7 from zarr.storage import BaseStore
      8 
      9 from .ngff_image import NgffImage

ModuleNotFoundError: No module named 'zarr.storage'
@kirbyju
Copy link
Owner Author

kirbyju commented Sep 24, 2024

Same issue in https://github.com/kirbyju/TCIA_Notebooks/blob/main/TCIA_MONAI_Model_Zoo.ipynb. I'm a bit conflicted about whether to keep maintaining this one in my repo. There is a nearly identical notebook at https://github.com/Project-MONAI/tutorials/blob/main/model_zoo/TCIA_PROSTATEx_Prostate_MRI_Anatomy_Model.ipynb. Perhaps it's better to just update that one and delete mine to reduce maintenance and potential confusion? I could cross link to the MONAI notebook from https://github.com/kirbyju/TCIA_Notebooks/blob/main/README.md to ensure people coming here would still find it if you all think that makes sense.

cc: @aylward

@kirbyju
Copy link
Owner Author

kirbyju commented Sep 24, 2024

It appears that reinstalling the zarr and ngff_zarr fixes the issue in both notebooks:

!pip uninstall -y zarr ngff_zarr
!pip install zarr ngff_zarr

Leaving this open until things are fixed within itkWidgets. Filed issue InsightSoftwareConsortium/itkwidgets#763 to track it.

thewtex added a commit to thewtex/TCIA_Notebooks that referenced this issue Oct 7, 2024
`pip install --pre` is likely to pick up zarr version 3 pre-release
packages which are unstable. To address kirbyju#30.

Also bump `itk` and `itkwidgets` to their latest versions, which contain
many improvements.
@thewtex
Copy link
Collaborator

thewtex commented Oct 7, 2024

@kirbyju a PR to address this is here: #31

@thewtex
Copy link
Collaborator

thewtex commented Oct 7, 2024

Colab with #31:

image

@thewtex
Copy link
Collaborator

thewtex commented Oct 8, 2024

Resolved via #31

@thewtex thewtex closed this as completed Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants