From b7d765758cff597b5cf2d75b46633799a268b583 Mon Sep 17 00:00:00 2001
From: Chris Smith <chris.smith@widerplan.com>
Date: Wed, 5 Jan 2022 11:57:57 +0000
Subject: [PATCH] Test valid return types

---
 tests/func_015.phpt | 43 +++++++++++++++++++++++++++++++++++--------
 tests/func_016.phpt | 43 +++++++++++++++++++++++++++++++++++--------
 2 files changed, 70 insertions(+), 16 deletions(-)

diff --git a/tests/func_015.phpt b/tests/func_015.phpt
index 4bd1e9d..067634d 100644
--- a/tests/func_015.phpt
+++ b/tests/func_015.phpt
@@ -12,16 +12,43 @@ timecop.func_override=0
 <?php
 declare(strict_types=1);
 
-foreach (['', (object) [], '1234', 4.5, true] as $input) {
+// Simplified version of:
+// https://github.com/symfony/polyfill/blob/6db783b3a48077f7102b6d7be6314d871eb7898c/src/Php80/Php80.php#L28-L58
+function var_type($value): string
+{
+    switch (true) {
+        case null === $value: return 'null';
+        case \is_bool($value): return 'bool';
+        case \is_string($value): return 'string';
+        case \is_array($value): return 'array';
+        case \is_int($value): return 'int';
+        case \is_float($value): return 'float';
+        case \is_object($value): return \get_class($value);
+    }
+
+    return 'unknown';
+}
+
+foreach (['', (object) [], '1234', 4.5, true, new \DateTimeImmutable(), new \DateTime(), 64] as $input) {
     try {
         var_dump(timecop_travel($input));
     } catch (TypeError $e) {
-        echo $e->getMessage(), "\n";
+        $message = $e->getMessage();
+
+        // Workaround exception message not including type in PHP 7 so the same test can be used for both.
+        if (PHP_MAJOR_VERSION === 7) {
+            $message = str_replace('N/A given', var_type($input).' given', $message);
+        }
+
+        echo $message, "\n";
     }
 }
---EXPECTREGEX--
-timecop_travel\(\): Argument #1 \(\$timestamp\) must be of type DateTimeInterface|int, (N\/A|string) given
-timecop_travel\(\): Argument #1 \(\$timestamp\) must be of type DateTimeInterface|int, (N\/A|stdClass) given
-timecop_travel\(\): Argument #1 \(\$timestamp\) must be of type DateTimeInterface|int, (N\/A|string) given
-timecop_travel\(\): Argument #1 \(\$timestamp\) must be of type DateTimeInterface|int, (N\/A|float) given
-timecop_travel\(\): Argument #1 \(\$timestamp\) must be of type DateTimeInterface|int, (N\/A|bool) given
+--EXPECT--
+timecop_travel(): Argument #1 ($timestamp) must be of type DateTimeInterface|int, string given
+timecop_travel(): Argument #1 ($timestamp) must be of type DateTimeInterface|int, stdClass given
+timecop_travel(): Argument #1 ($timestamp) must be of type DateTimeInterface|int, string given
+timecop_travel(): Argument #1 ($timestamp) must be of type DateTimeInterface|int, float given
+timecop_travel(): Argument #1 ($timestamp) must be of type DateTimeInterface|int, bool given
+bool(true)
+bool(true)
+bool(true)
diff --git a/tests/func_016.phpt b/tests/func_016.phpt
index 1de378f..6a024b7 100644
--- a/tests/func_016.phpt
+++ b/tests/func_016.phpt
@@ -12,16 +12,43 @@ timecop.func_override=0
 <?php
 declare(strict_types=1);
 
-foreach (['', (object) [], '1234', 4.5, true] as $input) {
+// Simplified version of:
+// https://github.com/symfony/polyfill/blob/6db783b3a48077f7102b6d7be6314d871eb7898c/src/Php80/Php80.php#L28-L58
+function var_type($value): string
+{
+    switch (true) {
+        case null === $value: return 'null';
+        case \is_bool($value): return 'bool';
+        case \is_string($value): return 'string';
+        case \is_array($value): return 'array';
+        case \is_int($value): return 'int';
+        case \is_float($value): return 'float';
+        case \is_object($value): return \get_class($value);
+    }
+
+    return 'unknown';
+}
+
+foreach (['', (object) [], '1234', 4.5, true, new \DateTimeImmutable(), new \DateTime(), 64] as $input) {
     try {
         var_dump(timecop_freeze($input));
     } catch (TypeError $e) {
-        echo $e->getMessage(), "\n";
+        $message = $e->getMessage();
+
+        // Workaround exception message not including type in PHP 7 so the same test can be used for both.
+        if (PHP_MAJOR_VERSION === 7) {
+            $message = str_replace('N/A given', var_type($input).' given', $message);
+        }
+
+        echo $message, "\n";
     }
 }
---EXPECTREGEX--
-timecop_freeze\(\): Argument #1 \(\$timestamp\) must be of type DateTimeInterface|int, (N\/A|string) given
-timecop_freeze\(\): Argument #1 \(\$timestamp\) must be of type DateTimeInterface|int, (N\/A|stdClass) given
-timecop_freeze\(\): Argument #1 \(\$timestamp\) must be of type DateTimeInterface|int, (N\/A|string) given
-timecop_freeze\(\): Argument #1 \(\$timestamp\) must be of type DateTimeInterface|int, (N\/A|float) given
-timecop_freeze\(\): Argument #1 \(\$timestamp\) must be of type DateTimeInterface|int, (N\/A|bool) given
+--EXPECT--
+timecop_freeze(): Argument #1 ($timestamp) must be of type DateTimeInterface|int, string given
+timecop_freeze(): Argument #1 ($timestamp) must be of type DateTimeInterface|int, stdClass given
+timecop_freeze(): Argument #1 ($timestamp) must be of type DateTimeInterface|int, string given
+timecop_freeze(): Argument #1 ($timestamp) must be of type DateTimeInterface|int, float given
+timecop_freeze(): Argument #1 ($timestamp) must be of type DateTimeInterface|int, bool given
+bool(true)
+bool(true)
+bool(true)