Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flow Concurrency tab didn't look well when nothing is running #5773

Open
loicmathieu opened this issue Nov 4, 2024 · 6 comments · May be fixed by #6640
Open

Flow Concurrency tab didn't look well when nothing is running #5773

loicmathieu opened this issue Nov 4, 2024 · 6 comments · May be fixed by #6640
Assignees
@hashimzs
Labels
area/frontend Needs frontend code changes bug Something isn't working good first issue Great issue for new contributors

Comments

@loicmathieu
Copy link
Member

Describe the issue

When no executions are running, the flow concurrency page didn't look well:
image

It should at least show the "no data" widget that we have everywhere instead of an empty area

Environment

  • Kestra Version: develop
@loicmathieu loicmathieu added bug Something isn't working area/backend Needs backend code changes area/frontend Needs frontend code changes labels Nov 4, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Issues Nov 4, 2024
@loicmathieu loicmathieu added good first issue Great issue for new contributors and removed area/backend Needs backend code changes labels Nov 4, 2024
@bharateshwq
Copy link

Hi I'd like to work on it
@loicmathieu , have you come across any no data page across the app, just to keep things consistent

@MilosPaunovic
Copy link
Member

Go for it @bharateshwq! 🚀 There is a kestra/ui/src/components/layout/EmptyState.vue page used for empty states, you can try and use that.

@MilosPaunovic MilosPaunovic mentioned this issue Nov 5, 2024
Open
@MilosPaunovic
Copy link
Member

Hi @bharateshwq,

Since there hasn't been any progress on the issue, I've unassigned you for now. If you decide to work on it and open a PR, let me know, and I'll be happy to reassign it to you.

In the meantime, the issue is open for anyone in the community who would like to take it on! 🚀

@hashimzs
Copy link
Contributor

hashimzs commented Jan 6, 2025

@MilosPaunovic can you assign me this ticket

@hashimzs hashimzs linked a pull request Jan 6, 2025 that will close this issue
Open
@hashimzs
Copy link
Contributor

hashimzs commented Jan 7, 2025 •
edited
Loading

@MilosPaunovic i have made a pr for this issue. however i am not sure where the translations have been written so title and description of the empty state are not being displayed properly

@MilosPaunovic
Copy link
Member

When working on translations, you need to edit the en.json file - we have automation to cover all the other languages based on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hashimzs hashimzs

Labels
area/frontend Needs frontend code changes bug Something isn't working good first issue Great issue for new contributors
Projects
Issues
Status: Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui): added empty view if there are no executions in progress hashimzs/kestra
4 participants
@loicmathieu @MilosPaunovic @bharateshwq @hashimzs