Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some code confused me. #1

Open
run1999 opened this issue Sep 1, 2022 · 0 comments
Open

Some code confused me. #1

run1999 opened this issue Sep 1, 2022 · 0 comments

Comments

@run1999
Copy link

run1999 commented Sep 1, 2022

Please check your code.

domains/s2orc/extract_papers.py

8 from joblib import Parallel, delayed
Does this Parallel module work in your code?

29 if len(papers) > 512:
I think it should be ‘==’ but not ‘>‘ , cause your shell script batch size is 512 , but your code create 513 files instead.

52 return metadata
Is this 'metadata' declared in the function?

By the way, I don't see your "get_metadata" used in the main function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant