Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test suite #16

Open
keikumata opened this issue Sep 23, 2020 · 0 comments
Open

Refactor test suite #16

keikumata opened this issue Sep 23, 2020 · 0 comments

Comments

@keikumata
Copy link
Owner

Currently we have multiple auth types to use ServiceBus (connection string, MSI clientID, MSI resourceID), and we have to duplicate the tests we write based on each auth type, like below:

--- PASS: TestPubSub (207.63s)
--- PASS: TestPubSub/TestCreateNewListenerWithConnectionString (0.00s)
--- PASS: TestPubSub/TestCreateNewListenerWithManagedIdentity (0.07s)
--- PASS: TestPubSub/TestCreatePublisherWithConnectionStringUsingExistingTopic (0.18s)
--- PASS: TestPubSub/TestCreatePublisherWithConnectionStringUsingNewTopic (2.34s)
--- PASS: TestPubSub/TestCreatePublisherWithManagedIdentityResourceIDUsingNewTopic (2.66s)
--- PASS: TestPubSub/TestCreatePublisherWithManagedIdentityUsingExistingTopic (0.40s)
--- PASS: TestPubSub/TestCreatePublisherWithManagedIdentityUsingNewTopic (2.49s)
--- PASS: TestPubSub/TestListenWithCustomFilter (20.01s)
--- PASS: TestPubSub/TestListenWithCustomFilterUsingManagedIdentity (20.02s)
--- PASS: TestPubSub/TestListenWithCustomSubscription (10.00s)
--- PASS: TestPubSub/TestListenWithDefault (10.00s)
--- PASS: TestPubSub/TestListenWithDefaultUsingManagedIdentity (10.00s)
--- PASS: TestPubSub/TestListenWithDefaultUsingManagedIdentityResourceID (10.00s)
--- PASS: TestPubSub/TestPublishAndListenWithConnectionStringUsingCustomHeaderFilter (20.24s)
--- PASS: TestPubSub/TestPublishAndListenWithConnectionStringUsingDefault (5.11s)
--- PASS: TestPubSub/TestPublishAndListenWithConnectionStringUsingDuplicateDetection (11.91s)
--- PASS: TestPubSub/TestPublishAndListenWithConnectionStringUsingTypeFilter (20.20s)
--- PASS: TestPubSub/TestPublishAndListenWithManagedIdentityUsingCustomHeaderFilter (20.13s)
--- PASS: TestPubSub/TestPublishAndListenWithManagedIdentityUsingDefault (5.19s)
--- PASS: TestPubSub/TestPublishAndListenWithManagedIdentityUsingDuplicateDetection (12.04s)
--- PASS: TestPubSub/TestPublishAndListenWithManagedIdentityUsingTypeFilter (20.29s)
PASS

We would really like to just pass in a token provider or an auth type into the test suite so we don't have to duplicate the tests every time we add a new feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant