From 3dcc0ac5c23bf40e74af82c2bd922a945f591054 Mon Sep 17 00:00:00 2001 From: fujiwara Date: Wed, 6 Nov 2024 13:39:26 +0900 Subject: [PATCH] fix null pointer exception --- run.go | 2 +- run_test.go | 3 ++- tests/td-in-tags.json | 1 - tests/td-plain-in-tags.json | 1 - tests/td-plain.json | 1 - 5 files changed, 3 insertions(+), 5 deletions(-) diff --git a/run.go b/run.go index bbc5e857..01077501 100644 --- a/run.go +++ b/run.go @@ -68,7 +68,7 @@ func (d *App) Run(ctx context.Context, opt RunOption) error { return err } if tdForRun.Arn == "" && tdForRun.TaskDefinitionInput != nil { - d.Log("Task definition family %s will be registered", *tdForRun.TaskDefinitionInput.Family) + d.Log("Task definition family %s will be registered", aws.ToString(tdForRun.TaskDefinitionInput.Family)) } else { d.Log("Task definition ARN: %s", tdForRun.Arn) var err error diff --git a/run_test.go b/run_test.go index 4d7b0f66..8285ae80 100644 --- a/run_test.go +++ b/run_test.go @@ -4,6 +4,7 @@ import ( "context" "testing" + "github.com/aws/aws-sdk-go-v2/aws" "github.com/aws/aws-sdk-go-v2/config" "github.com/aws/smithy-go/middleware" "github.com/kayac/ecspresso/v2" @@ -131,7 +132,7 @@ func TestTaskDefinitionArnForRun(t *testing.T) { t.Errorf("%s %s expected %s, got %s", config, args, s.arn, name) } } else { - family := *td.TaskDefinitionInput.Family + family := aws.ToString(td.TaskDefinitionInput.Family) if family != s.family { t.Errorf("%s %s expected %s, got %s", config, args, s.family, family) } diff --git a/tests/td-in-tags.json b/tests/td-in-tags.json index dcb962ab..164a2b9b 100644 --- a/tests/td-in-tags.json +++ b/tests/td-in-tags.json @@ -55,7 +55,6 @@ "volumesFrom": [] } ], - "revision": 1, "cpu": "1024", "memory": "2048", "proxyConfiguration": { diff --git a/tests/td-plain-in-tags.json b/tests/td-plain-in-tags.json index f636fa80..6db1c82b 100644 --- a/tests/td-plain-in-tags.json +++ b/tests/td-plain-in-tags.json @@ -54,7 +54,6 @@ "volumesFrom": [] } ], - "revision": 1, "cpu": "1024", "memory": "2048", "proxyConfiguration": { diff --git a/tests/td-plain.json b/tests/td-plain.json index 5088ce30..e1091c2e 100644 --- a/tests/td-plain.json +++ b/tests/td-plain.json @@ -54,7 +54,6 @@ "volumesFrom": [] } ], - "revision": 1, "cpu": "1024", "memory": "2048", "proxyConfiguration": {