From 4d2d147f17e27df1d2a64226369af5e46192eab2 Mon Sep 17 00:00:00 2001 From: fujiwara Date: Fri, 12 Jul 2024 10:45:17 +0900 Subject: [PATCH] fix: verify ssm secrets from SSM parameters. It did not fail even if the ssm parameter was missing. --- verify.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/verify.go b/verify.go index 8b465b86..83156191 100644 --- a/verify.go +++ b/verify.go @@ -117,7 +117,7 @@ func (v *verifier) existsSecretValue(ctx context.Context, from string) error { } else { name = from } - _, err := v.ssm.GetParameters(ctx, &ssm.GetParametersInput{ + out, err := v.ssm.GetParameters(ctx, &ssm.GetParametersInput{ Names: []string{name}, WithDecryption: aws.Bool(true), }) @@ -138,6 +138,9 @@ func (v *verifier) existsSecretValue(ctx context.Context, from string) error { return fmt.Errorf("failed to get ssm parameters %s: %w", name, err) } } + if len(out.Parameters) == 0 || len(out.InvalidParameters) > 0 { + return fmt.Errorf("ssm parameter %s is not found", name) + } return nil }