changes after tim talk

kabanero-io · Jun 15, 2020 · 310d08e · 310d08e
1 parent 27adb56
commit 310d08e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 7 deletions.
diff --git a/config/orchestrations/cli-services/0.2/kabanero-cli.yaml b/config/orchestrations/cli-services/0.2/kabanero-cli.yaml
@@ -89,7 +89,7 @@ rules:
   verbs:
   - '*'
 - apiGroups:
-  - kabanero.io
+  - apps
   resources:
   - deployments
   verbs:

diff --git a/deploy/kabanero-customresources.yaml b/deploy/kabanero-customresources.yaml
@@ -565,13 +565,10 @@ metadata:
   namespace: kabanero
   labels:
     kabanero.io/install: 27-cli-service-role
-subjects:
-- kind: ServiceAccount
-- name: kabanero-cli
-- namespace: kabanero
 rules:
 - apiGroups:
-  - rbac.authorization.k8s.io
+  - extensions
+  - apps
   resources:
   - deployments
   verbs:

diff --git a/pkg/controller/kabaneroplatform/targetnamespaces.go b/pkg/controller/kabaneroplatform/targetnamespaces.go
@@ -69,7 +69,6 @@ func createBindingTemplates(saNamespace string) []targetNamespaceRoleBindingTemp
 			saNamespace:     saNamespace,
 			clusterRoleName: "kabanero-pipeline-deploy-role",
 		},
-		// TODO: Second role binding for CLI service
 		{
 			name:            "kabanero-cli-deploy-rolebinding",
 			saName:          "kabanero-cli",