Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wheel_installer causes rules_python deprecation warning #148

Open
lalten opened this issue Jan 25, 2025 · 1 comment
Open

wheel_installer causes rules_python deprecation warning #148

lalten opened this issue Jan 25, 2025 · 1 comment

Comments

@lalten
Copy link

lalten commented Jan 25, 2025

After upgrading to rules_python 1.1.0, (rules_pycross 0.7.1), I'm getting a warning from rules_python about a deprecated alias:

https://github.com/lalten/rules_appimage/actions/runs/12968177491/job/36170887084?pr=280#step:6:54

WARNING: /home/runner/.cache/bazel/_bazel_runner/98a5b15d41eaf418ed0fd79d24a54d98/external/rules_pycross++lock_repos+pdm_deps/_lock/BUILD.bazel:5:8: in pycross_wheel_library rule @@rules_pycross++lock_repos+pdm_deps//_lock:[email protected]: target '@@rules_pycross++lock_repos+pdm_deps//_lock:[email protected]' depends on deprecated target '@@rules_pycross+//pycross/private/tools:wheel_installer': 
The py_binary symbol in @rules_python//python/config_settings:transition.bzl
is deprecated. It is an alias to the regular rule; use it directly instead:
    load("@rules_python//python:py_binary.bzl", "py_binary")

Not sure what is causing this?

@jvolkman
Copy link
Owner

That deprecation warning came with rules_python 1.1.0 in bazelbuild/rules_python#2541. I think removing it currently would require rules_pycross to depend on 1.1.0 at a minimum and change to the new usage. As far as I can tell, the new usage that the warning points to is not compatible with 1.0.0.

It looks like the warning will be silenced by default with the next version: bazelbuild/rules_python@188598a#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR57-R59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants