Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with Bazel 6 #147

Open
lalten opened this issue Jan 25, 2025 · 4 comments
Open

Incompatible with Bazel 6 #147

lalten opened this issue Jan 25, 2025 · 4 comments

Comments

@lalten
Copy link

lalten commented Jan 25, 2025

In https://github.com/lalten/rules_appimage/actions/runs/12967356868/job/36169139114?pr=276, which tests rules_appimage compatibility with rules_pycross on Bazel 6 and Bzlmod, I'm getting:

ERROR: https://bcr.bazel.build/modules/rules_jvm_external/6.3/MODULE.bazel:101:13: name 'use_repo_rule' is not defined
ERROR: Error computing the main repository mapping: in module dependency chain <root> -> [email protected] -> [email protected] -> [email protected] -> [email protected]: error executing MODULE.bazel file for [email protected]

I don't have a problem with rules_pycross dropping Bazel 6 support. But it would be nice to set bazel_compatibility in the module() (https://bazel.build/rules/lib/globals/module#module) (or somehow make sure dependency compatiblity_levels are such that use_repo_rule isn't used)

lalten added a commit to lalten/rules_appimage that referenced this issue Jan 25, 2025
@jvolkman
Copy link
Owner

Did [email protected] also drop support for Bazel 6? It seems like that's where we're picking up this dependency. If not, how did they solve this?

@lalten
Copy link
Author

lalten commented Jan 25, 2025

@lalten
Copy link
Author

lalten commented Jan 25, 2025

looks like this isn't the first time people stumble over that: bazel-contrib/rules_jvm_external#1055 :)

@lalten
Copy link
Author

lalten commented Jan 25, 2025

But actually the bazel_compatibility is set to [">=7.0.0"] in rules_jvm_external 6.3: https://github.com/bazel-contrib/rules_jvm_external/blob/2deeda518cf1ccb847c6e188bb3bf7d3f6fb7496/MODULE.bazel#L1-L5 so I'm not sure how Bazel picked up this dependency in the first place 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants