Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve/streamline plot functions #23

Open
1 of 4 tasks
juanfung opened this issue Aug 1, 2024 · 8 comments
Open
1 of 4 tasks

Improve/streamline plot functions #23

juanfung opened this issue Aug 1, 2024 · 8 comments

Comments

@juanfung
Copy link
Owner

juanfung commented Aug 1, 2024

Current plot functions are kludgey. Needs

  • Wrapper to streamline plotting as inputs are the same (same goes for postprocessing code)
  • Global plot theme (so this isn't getting done ad hoc with each plot) Define plot theme globally #14
  • Plotting other metrics
  • EDIT: filtering by model list should actually be by design (intervention); need to update preprocessing to create this column, with plain english names, for easy plotting (as this is getting done ad hoc for plotting from the outputs)
@juanfung
Copy link
Owner Author

juanfung commented Aug 2, 2024

Update postprocessing functions so that:

  • Expected input is not entire model name (eg, RCMF-4-baseline-nsfr)
  • Instead, filter by system, design, and num_stories, with defaults
    • system = "RCMF
    • design = "baseline-nsfr`
    • num_stories = 4

@juanfung
Copy link
Owner Author

juanfung commented Aug 2, 2024

  • Rename existing (postprocess|plot)_eal functions to more accurate (postprocess|plot)_eal_by_design, as these function really disaggregate EALs to report bar chart of by loss categories, for a single design
  • Create new (postprocess|plot)_eal functions to summarize EALs across range of systems and stories
  • Repeat for (postprocess|plot)_bcr

@juanfung
Copy link
Owner Author

juanfung commented Aug 2, 2024

  • EDIT: filtering by model list should actually be by design (intervention); need to update preprocessing to create this column, with plain english names, for easy plotting (as this is getting done ad hoc for plotting from the outputs)

UPDATE: resolved by 3282cae

juanfung added a commit that referenced this issue Aug 2, 2024
…lysis vs multi-design baseline BCRs, including more flexible inputs (system, design, stories)
@juanfung
Copy link
Owner Author

juanfung commented Aug 2, 2024

  • Repeat for (postprocess|plot)_bcr

Resolved by b0f54b9, which created separate baseline and sensitivity BCR plots

@juanfung
Copy link
Owner Author

juanfung commented Aug 2, 2024

  • Rename existing (postprocess|plot)_eal functions to more accurate (postprocess|plot)_eal_by_design, as these function really disaggregate EALs to report bar chart of by loss categories, for a single design
  • Create new (postprocess|plot)_eal functions to summarize EALs across range of systems and stories

UPDATE: Resolved by d874a92

Note the plot_eal function is broken down into two functions: one for total EALs across systems (currently a placeholder) and one for disaggregated EALs by loss category (plot_eal_by_loss)

@juanfung
Copy link
Owner Author

juanfung commented Aug 2, 2024

Update postprocessing functions so that:

  • Expected input is not entire model name (eg, RCMF-4-baseline-nsfr)

  • Instead, filter by system, design, and num_stories, with defaults

    • system = "RCMF
    • design = "baseline-nsfr`
    • num_stories = 4

Resolved by b0f54b9 and d874a92

@juanfung
Copy link
Owner Author

juanfung commented Aug 2, 2024

  • Update placeholder plot_eal to plot EALs across multiple systems

juanfung added a commit that referenced this issue Aug 2, 2024
…ple systems to disaggregated EAL plot (plot_eal_by_loss)
@juanfung
Copy link
Owner Author

juanfung commented Aug 2, 2024

  • Update placeholder plot_eal to plot EALs across multiple systems

UPDATE: Resolved by d85f9a1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant