Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Enhancement: Publication page for new format registry #1130

Open
gregsdennis opened this issue Nov 21, 2024 · 30 comments
Open

✨ Enhancement: Publication page for new format registry #1130

gregsdennis opened this issue Nov 21, 2024 · 30 comments
Labels
✨ Enhancement Indicates that the issue suggests an improvement or new feature. help wanted Extra attention is needed

Comments

@gregsdennis
Copy link
Member

Is your feature request related to a problem? Please describe

We're looking at starting an official registry for format values. See the proposal issue for more context.

Describe the solution you'd like

We need a place on the website to publish the list of formats. I expect that we'd want something that functions similarly to the tooling page that pulls from a source/data file (which we'd probably keep in the spec repo, but open to keeping it somewhere else).

The page itself needs to be closely associated with the specifications, so alongside those might be a good location.

For now, I think we just need design and publication ideas. Please have a read through the issue linked above to get the full idea we're going for.

Describe alternatives you've considered

No response

Additional context

This discussion should be limited to the page itself. We can take input on what you might need/want from the source/data file, but ultimately its content will be determined by the TSC / Spec Team.

Are you working on this?

No

@gregsdennis gregsdennis added ✨ Enhancement Indicates that the issue suggests an improvement or new feature. Status: Triage This is the initial status for an issue that requires triage. labels Nov 21, 2024
@gregsdennis gregsdennis changed the title ✨ Enhancement: ✨ Enhancement: Publication page for new format registry Nov 21, 2024
@benjagm
Copy link
Collaborator

benjagm commented Nov 23, 2024

This is a really cool idea! Thanks, @gregsdennis! Is there an example of pages with similar functionality of what you have in mind?

@gregsdennis
Copy link
Member Author

I have no ideas. That's the purpose of this issue.

@valeriahhdez valeriahhdez added help wanted Extra attention is needed Status: Available No one has claimed responsibility for resolving this issue. and removed Status: Triage This is the initial status for an issue that requires triage. labels Jan 6, 2025
@rishabhknowss
Copy link
Contributor

( It's just the design idea )
Screenshot from 2025-01-05 18-53-48

@rishabhknowss
Copy link
Contributor

Also, how will we be storing these formats data, i mean from where will we be fetching the content?

@gregsdennis
Copy link
Member Author

Also, how will we be storing these formats data, i mean from where will we be fetching the content? - @rishabhknowss

We will not be storing anything. We are a list. Many of the formats are defined by our Validation specification. Other formats will be defined by other specifications. We just need to list and perhaps link to where the definition for each format is.

@gregsdennis
Copy link
Member Author

@abhayymishraa I've hidden your comment as it doesn't pertain to this issue. It's more related to the registry itself. This is just how that registry is represented on the site. Your ideas (and please just include the high-level concepts, not the full-blown proposal) should be mentioned there.

@abhayymishraa
Copy link
Contributor

abhayymishraa commented Jan 7, 2025

I just understood . what about if we built the registry within the website. there will be a specific section for the registry and there we will implement make a interface for the registry of something like openAPI fromat. And we'll make a section where we list and link the defination of each format.

@gregsdennis
Copy link
Member Author

gregsdennis commented Jan 7, 2025

@abhayymishraa The registry will be hosted and managed in Github. The website is just a rendering. I'll continue this discussion offline in Slack.

@rishabhknowss
Copy link
Contributor

Also, how will we be storing these formats data, i mean from where will we be fetching the content? - @rishabhknowss

We will not be storing anything. We are a list. Many of the formats are defined by our Validation specification. Other formats will be defined by other specifications. We just need to list and perhaps link to where the definition for each format is.

got it !

@shantanu2107
Copy link
Contributor

hi @benjagm , can I work on this issue, if no one is working?

@gregsdennis
Copy link
Member Author

gregsdennis commented Jan 9, 2025

@shantanu2107 please read the discourse above. There needs to be discussion on what is to be done before this issue is assigned. There is a screenshot of a mockup someone did as an idea, but we haven't agreed on anything.

We haven't even designed the registry (linked issue) which needs to be done before this work can be done.

@gregsdennis gregsdennis removed the Status: Available No one has claimed responsibility for resolving this issue. label Jan 9, 2025
@gregsdennis
Copy link
Member Author

Alright, I think we have some ideas on what we're looking for from a technical perspective on the registry. Please see the issue (linked at the top) for that.

@rishabhknowss since it's not too far off from your design, can you make an update that fits the data we're looking for? Your data source will be a file in the spec repository. Also, please describe what any functional parts of your design are supposed to do. Lastly, we need it to fit in with the current website design.

@rishabhknowss
Copy link
Contributor

Alright @gregsdennis !! Working on it

@gregsdennis
Copy link
Member Author

It's also important to note that this is still in progress. We're still in design. No PRs yet, please.

@rishabhknowss
Copy link
Contributor

Got it

@rishabhknowss
Copy link
Contributor

Hello @gregsdennis , is the jsonschema-validation.md file in the spec repository the right source for the format data? Just want to confirm before I proceed. Thanks!

@gregsdennis
Copy link
Member Author

I've opened a new PR that creates a new file. It's linked to the issue.

@rishabhknowss
Copy link
Contributor

okay

@gregsdennis
Copy link
Member Author

gregsdennis commented Jan 15, 2025

@rishabhknowss please also have a look at https://spec.openapis.org/registry/format/index.html. We will be inheriting these. I'll make sure they're in the file, but the file schema may need to be updated.

@rishabhknowss
Copy link
Contributor

@rishabhknowss please also have a look at https://spec.openapis.org/registry/format/index.html. We will be inheriting these. I'll make sure they're in the file, but the file schema may need to be updated.

Thanks for the update! I'll be looking at it

@benjagm
Copy link
Collaborator

benjagm commented Jan 16, 2025

Hi Greg and everyone. What do you think about adding this project as a project Idea for GSoC 2025?

@gregsdennis
Copy link
Member Author

I don't know that there's really a whole lot to do, and @rishabhknowss has already started designs.

I'd also like it to be done sooner than the northern summer. Hopefully the spec is out before then, and we need this before the spec.

@rishabhknowss
Copy link
Contributor

Yes, I agree it won't take much time. Once I'll post the designs (planning to add some functional components) , i would love to code the implementation later.

I don't know that there's really a whole lot to do, and @rishabhknowss has already started designs.

I'd also like it to be done sooner than the northern summer. Hopefully the spec is out before then, and we need this before the spec.

@Karan-Palan
Copy link
Contributor

@rishabhknowss let's work collaboratively on this issue if that's alright with you. This will be a great addition to the site

@rishabhknowss
Copy link
Contributor

@rishabhknowss let's work collaboratively on this issue if that's alright with you. This will be a great addition to the site

hey @Karan-Palan i'm already working on this issue, if i require your help at any step I'll let you know, thanks :>

@Karan-Palan
Copy link
Contributor

@rishabhknowss thanks for the update! This seems like a significant change, and I thought it could benefit from collaborative efforts to cover all aspects efficiently. I’d be happy to assist if needed or help brainstorm ideas.

@rishabhknowss
Copy link
Contributor

rishabhknowss commented Jan 16, 2025

Hi @gregsdennis @benjagm . I have used the data from specs/format-registry.json I believe the designs have been adjusted to align with the website's theme and should look great :D
Please let me know if you have any feedback.

Format Registry Page Design

Desktop Screen

Desktop Screen

Mobile Screens

Mobile Screen 1 Mobile Screen 2

Dark mode

Image


Functional Components

1. Search Box

Search for a specific format by typing its name or keywords.

Search Box

2. Specification Selector

Choose formats by their specifications (e.g., char under OpenAPI, date-time under JSON Schema).

Specification Selector

3. Data Type Filters

Filter formats by String or Number data types.

Data Type Filters

@gregsdennis
Copy link
Member Author

I like it. Hold onto this, and when we're finalized on the source file and merge that PR, we can finalize this and bring it in.

@rishabhknowss
Copy link
Contributor

I like it. Hold onto this, and when we're finalized on the source file and merge that PR, we can finalize this and bring it in.

Okay

@benjagm
Copy link
Collaborator

benjagm commented Jan 17, 2025

This looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Enhancement Indicates that the issue suggests an improvement or new feature. help wanted Extra attention is needed
Projects
Status: No status
Development

No branches or pull requests

7 participants