Research Advancement Division : Contracts derived from RAD_Surface.cfg cannot be completed and have duplicate subjects

[splatpope]

See this issue on the RAD repo, please check the concerned config file (RAD_Surface.cfg) for more details about how it is configured.

The first obvious issue is that the list of ScienceSubjects used in the core CollectScience generally has duplicates, even though nothing suggests this is due in any way to the configuration file.

The second issue is that those subjects are never truly counted as having their science recovered : it shows as much when you transmit the experiments during flight (showing green checkmarks next to the subject title and hiding the recovery method), but after the vessel is recovered, the list becomes totally unchecked once again. The core CollectScience parameter is never counted as complete.

On certain times, after recovering the science (not transmitting), the list becomes checked at the KSC, but the CollectScience parameter still doesn't get complete.

After checking the source code in this repo, it seems that a hook called OnScienceRecovered should be fired, with verbose logging, but no such lines appear in my log. Apparently ALT+F10 shows a debug screen where this verbouse output is probably located, I will investigate.

My mod list is pretty extensive, which may indicate that some undocumented incompatibilities are the cause of this issue, although a couple of other users have reported a similar bug in RAD's KSP forum thread.

KSP.log_splatpope_20241201.zip

[splatpope]

I managed to get rid of the issues after uninstalling some mods, here are the two modlists :

Before :
splatpope_ksp_list_20241201.txt

After :
splatpope_ksp_list_20241203.txt

Diff:
PS C:\Users\splatpope> diff (Get-Content -Path .\Downloads\splatpope_ksp_list_20241201.txt) (Get-Content -Path .\Downloads\splatpope_ksp_list_20241203.txt)

InputObject SideIndicator

---

Airplane Plus (AirplanePlus 26.5) <=
BonVoyage (BonVoyage 1:1.4.1) <=
CapCom - Mission Control On The Go (CapCom 2.11) <=
CommNet Antennas Consumptor (CommNetAntennasConsumptor 3.5.8) <=
CommNet Antennas Extension (CommNetAntennasExtension 2.1.9) <=
CommNet Antennas Info (CommNetAntennasInfo 3.1.4) <=
Contract Parser (ContractParser 9.0) <=
Contracts Window + (ContractsWindowPlus 9.4) <=
DaMichel's SphericalTanks (DST) (DMTanks-SphericalTanks 1:1.1.0.0) <=
Firespitter Core (FirespitterCore v7.17) <=
Firespitter Resources config (FirespitterResourcesConfig v7.17) <=
HUD Replacer (HUDReplacer 1.2.12-beta) <=
Keridian Dynamics (KDVA) by Eleusis La Arwal (KeridianDynamicsVesselAssembly 0.8.99.5-prerelease) <=
KSP Recall (KSP-Recall v0.5.0.2) <=
Lazy Painter (LazyPainter v0.4.0) <=
Near Future Rovers (NFR) by V2 Industries by MichaelV2.0 (RoverPack 2.0.99.0-adoption) <=
Not So SimpleConstruction! (NSSC) (NotSoSimpleConstruction 1.0.99.3-prerelease) <=
Progress Parser (ProgressParser 11.0) <=
RealChute Parachute Systems (RealChute v1.4.9.5) <=
RemoteTech Redev Antennas (RemoteTechRedevAntennas 0.1.1) <=
TU NearFutureAero (RecolorCollection-NearFutureAeronautics v1.3.1) <=
TU NearFutureLaunchVehicles (RecolorCollection-NearFutureLaunchVehicles v1.0) <=
TweakScale - Rescale Everything! (TweakScale v2.4.8.6) <=
TweakScale Companion (the "UberPaket") (TweakScaleCompanion 2024.10.9.1) <=

I would put my bets on the various contract-related mods.

Sadly, I am not willing to do the differential testing required to find out which of these mods cause the issue. Hopefully, someone more motivated than me will do that and be a hero

I think that just trying to reproduce them using my first modlist might already be a good step forward