Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopts mdo's style guide for CSS (and HTML) #71

Closed
jzaefferer opened this issue Mar 6, 2014 · 3 comments
Closed

Adopts mdo's style guide for CSS (and HTML) #71

jzaefferer opened this issue Mar 6, 2014 · 3 comments

Comments

@jzaefferer
Copy link
Member

This style guide for CSS looks pretty good to me: http://mdo.github.io/code-guide/#css

While that is online and actively maintained, we could just link to it. Its MIT licensed, so we could also integrate it here.

From the HTML section we could take over the sections on "Attribute order" and "Boolean attributes", if we want to adopt those.

@scottgonzalez
Copy link
Member

There are multiple differences between our CSS style and mdo's CSS style.

  • We never use soft tabs.
  • We don't change spacing rules for commas based on location.
  • We don't use spaces to line up multiple rules.
  • We don't collapse single property rules to one line.
  • We're planning on switching to BEM so class naming is very different.

@scottgonzalez
Copy link
Member

For HTML, I think we already follow the boolean attributes rule, though we do have some files that need to be valid XHTML, so it's not possible there.

I disagree with the attribute ordering. I think type should always be first for <input>.

@jzaefferer
Copy link
Member Author

Not much left over then. I'll leave it to @uGoMobi to write a style guide for CSS, if he's interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants