Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLA Checker: Show time of attempted verification #110

Closed
gibson042 opened this issue Apr 4, 2015 · 3 comments
Closed

CLA Checker: Show time of attempted verification #110

gibson042 opened this issue Apr 4, 2015 · 3 comments

Comments

@gibson042
Copy link
Member

For technical reasons, we don't automatically recheck pull requests when a contributor signs the CLA. But pages/CLA/status.md doesn't provide enough information on its own to detect post-failure resolution, because it lacks the invocation time.

We should add text to the effect of "The following authors didn't have appropriate CLA signatures as of [datetime]", and also instructions to reactivate the checker by pushing a new commit to each affected pull request (perhaps suggesting git commit --allow-empty -m '[CLA]: Recheck').

@cvrebert
Copy link

cvrebert commented Apr 4, 2015

Have you considered having the bot listen for PR comments and having some magic comment force a CLA re-check?

@arschmitz
Copy link
Member

@gibson042 @cvrebert The only reason we don't currently re-check is just that it has not been implemented, the cla checker is very new. There are 2 open issues for this jquery/jquery-license#2 to implement the ability to recheck a PR, and jquery/jquery-license#6 Which is to implement auto re-checks ( and also includes discussion of re-checking based on comments )

--allow-empty would work just not sure we want to recommend that? @scottgonzalez thoughts?

@scottgonzalez
Copy link
Member

Moved to jquery/jquery-license#30 since that's where we've been tracking all of the CLA checker changes.

I'd rather see someone just implement jquery/jquery-license#6 instead of suggesting empty commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants