You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the class method fetch of class TxFetcher the line cls.cache[tx_id].testnet = testnet appears outside of the preceding if branch causing an unnecessary reassignment of the field testnet of the transaction when there has been a cache hit (ie. when both fresh and tx_id not in cls.cache equal False). This assignment should only be made if we are entering a new transaction into the cache (ie. a cache miss) or refreshing an existing transaction in the cache due to the fresh parameter being True - ie. when we enter the if branch. Thus the line cls.cache[tx_id].testnet = testnet should be indented one tab to appear within the if branch. This bug does not cause the code to malfunction but fixing it would clarify the code for reading.
The text was updated successfully, but these errors were encountered:
In the class method
fetch
of classTxFetcher
the linecls.cache[tx_id].testnet = testnet
appears outside of the precedingif
branch causing an unnecessary reassignment of the fieldtestnet
of the transaction when there has been a cache hit (ie. when bothfresh
andtx_id not in cls.cache
equalFalse
). This assignment should only be made if we are entering a new transaction into the cache (ie. a cache miss) or refreshing an existing transaction in the cache due to thefresh
parameter beingTrue
- ie. when we enter theif
branch. Thus the linecls.cache[tx_id].testnet = testnet
should be indented one tab to appear within theif
branch. This bug does not cause the code to malfunction but fixing it would clarify the code for reading.The text was updated successfully, but these errors were encountered: