Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify failed_when #9

Open
jimbo8098 opened this issue Aug 17, 2022 · 0 comments
Open

Simplify failed_when #9

jimbo8098 opened this issue Aug 17, 2022 · 0 comments

Comments

@jimbo8098
Copy link
Owner

This can be more efficient:

windows-docker-role/tasks/main.yml

Line 8 in 775c0bd

failed_when: powershell_res.rc != 0 and powershell_res.rc != 1603

1603 is a generic error so really all this failed_when does is ensure that the command exited successfully. No need to overcomplicate here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jimbo8098