From f3652f77b4e54773c27123a62df252b0683d46aa Mon Sep 17 00:00:00 2001
From: Sami Jaber <jabersami@gmail.com>
Date: Fri, 20 Jan 2023 13:12:36 -0400
Subject: [PATCH] Fix extensions (#992)

* fix extensions

* remove log
---
 packages/cli/src/build/helpers/extensions.ts          | 7 ++++---
 packages/core/src/helpers/replace-identifiers.test.ts | 5 +----
 2 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/packages/cli/src/build/helpers/extensions.ts b/packages/cli/src/build/helpers/extensions.ts
index 5d8e6acc78..b02aaa17d3 100644
--- a/packages/cli/src/build/helpers/extensions.ts
+++ b/packages/cli/src/build/helpers/extensions.ts
@@ -28,16 +28,17 @@ export const getFileExtensionForTarget = ({
       return '.ts';
     case 'lit':
       return '.ts';
+
+    // all JSX frameworks
     case 'solid':
     case 'qwik':
-      return isTs && type === 'filename' ? '.tsx' : '.jsx';
     case 'react':
     case 'reactNative':
     case 'rsc':
       switch (type) {
-        // we can't have `.jsx`/`.tsx` extensions in the import paths.
         case 'import':
-          return isTs ? '.ts' : '.js';
+          // we can't have `.jsx`/`.tsx` extensions in the import paths, so we stick with implicit file extensions.
+          return '';
         case 'filename':
           return isTs ? '.tsx' : '.jsx';
       }
diff --git a/packages/core/src/helpers/replace-identifiers.test.ts b/packages/core/src/helpers/replace-identifiers.test.ts
index d8786d82be..f6a0a29e8f 100644
--- a/packages/core/src/helpers/replace-identifiers.test.ts
+++ b/packages/core/src/helpers/replace-identifiers.test.ts
@@ -61,10 +61,7 @@ const TEST_SPECS: Spec[] = [
     const bar = foo;
     `,
     from: ['foo', 'test'],
-    to: (name) => {
-      console.log({ name });
-      return `${name}.value`;
-    },
+    to: (name) => `${name}.value`,
   },
 ];