Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PLT if dependency has changed #409

Open
velimir opened this issue Aug 14, 2020 · 2 comments
Open

Update PLT if dependency has changed #409

velimir opened this issue Aug 14, 2020 · 2 comments

Comments

@velimir
Copy link

velimir commented Aug 14, 2020

Current behavior

dialyxir checks that the old built plt contains the updated information about depencencies based on the hash of the lock and remove/add files that are not in the plt if necessary.
If one of the depencies were changes, though the list of the files remain the same, plt for the changed files won't be rebuilt.

Expected behavior

dialyxir tracks version/hashsum of the depenencies that plt was built with and updates the plt if beam has changed.

@jeremyjh
Copy link
Owner

Sorry can you elaborate on this? How does a dependency change without changing the lock file? Is it a local dependency?

@velimir
Copy link
Author

velimir commented Sep 18, 2020

The root of this issue was an attempt to make a single project re-use dependency PLTs.

You are absolutely right, if a dependency is changed, the lock (and the hash of it) is changed as well, which triggers PLT re-build for all dependencies.
If the PLT hash were implemeted on per dependency (or a file) level, it would allow to speed up the process rebuilding PLT only for dependencies/files that were changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants