Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Contract For Erlex Errors #370

Open
asummers opened this issue Nov 7, 2019 · 1 comment
Open

Change Contract For Erlex Errors #370

asummers opened this issue Nov 7, 2019 · 1 comment

Comments

@asummers
Copy link
Collaborator

asummers commented Nov 7, 2019

Because of the history of Erlex being inside Dialyxir, we throw on errors because it was used as a sort of control flow. This is gross and nonidiomatic for cross project errors, and we should raise or provide error tuples. Because this is a breaking change to Erlex, Dialyxir will need to tolerate both style error messages. This begs a few back compat questions about if we even care to maintain and sequencing questions, as qell as poses design questions of how we actually want Erlex errors to manifest in Dialyxir for maximum flexibility.

@jeremyjh
Copy link
Owner

jeremyjh commented Nov 7, 2019

I'm fine with a change in contract and supporting both in Dialyxir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants