From a6f801f103ece1058e6d1a85d53d26242c1bc03c Mon Sep 17 00:00:00 2001 From: "J.C. Jones" Date: Wed, 5 Jun 2024 22:24:45 -0700 Subject: [PATCH] Use mandatory args --- src/client/client.py | 2 +- src/watersmart/__init__.py | 2 +- src/watersmart/usage_data_test.py | 4 +++- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/client/client.py b/src/client/client.py index 5391034..b859adc 100644 --- a/src/client/client.py +++ b/src/client/client.py @@ -28,7 +28,7 @@ async def main(): args = PARSER.parse_args() log_format = "%(asctime)s - %(name)s - %(levelname)s - %(message)s" logging.basicConfig(level=args.log_level, format=log_format) - wc = WatersmartClient(args.url, args.email, args.password) + wc = WatersmartClient(url=args.url, email=args.email, password=args.password) try: data = await wc.usage() for datapoint in sorted(data, key=lambda x: x["read_datetime"]): diff --git a/src/watersmart/__init__.py b/src/watersmart/__init__.py index f73d46e..c852ba1 100644 --- a/src/watersmart/__init__.py +++ b/src/watersmart/__init__.py @@ -24,7 +24,7 @@ class WatersmartClientAuthenticationError(WatersmartClientError): class WatersmartClient: - def __init__(self, url, email, password, session=None): + def __init__(self, *, url, email, password, session=None): self._url = url self._email = email self._password = password diff --git a/src/watersmart/usage_data_test.py b/src/watersmart/usage_data_test.py index 9f29751..2253027 100644 --- a/src/watersmart/usage_data_test.py +++ b/src/watersmart/usage_data_test.py @@ -45,4 +45,6 @@ def test_amend_with_local_ts_in_utc(): @pytest.mark.asyncio async def test_disallow_non_watersmart_urls(): with pytest.raises(AssertionError): - WatersmartClient("https://wsmart.example", "e@mail", "passw4rd") + WatersmartClient( + url="https://wsmart.example", email="e@mail", password="passw4rd" + )