Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(wrapper): add wrapper for marketplace frontend, backend and catalog-backend-module plugins #2156

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

karthikjeeyar
Copy link
Contributor

@karthikjeeyar karthikjeeyar commented Jan 8, 2025

Description

Add dynamic plugin wrappers for marketplace, marketplace-backend and catalog-backend-module-marketplace plugins.

Which issue(s) does this PR fix

https://issues.redhat.com/browse/RHIDP-5322

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@karthikjeeyar karthikjeeyar requested a review from a team as a code owner January 8, 2025 10:53
Copy link

openshift-ci bot commented Jan 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nilgaar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karthikjeeyar karthikjeeyar force-pushed the add-marketplace-wrapper branch 6 times, most recently from fcaa58e to 62d25cc Compare January 8, 2025 16:23
@karthikjeeyar karthikjeeyar force-pushed the add-marketplace-wrapper branch from 62d25cc to 0c4d778 Compare January 8, 2025 16:39
@ciiay
Copy link
Contributor

ciiay commented Jan 8, 2025

/test e2e-tests

Copy link

openshift-ci bot commented Jan 8, 2025

@karthikjeeyar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests 0c4d778 link true /test e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants