Skip to content
This repository has been archived by the owner on Jan 3, 2019. It is now read-only.

Default layout's link attribute gets overridden #21

Open
kngroo opened this issue Dec 7, 2016 · 0 comments
Open

Default layout's link attribute gets overridden #21

kngroo opened this issue Dec 7, 2016 · 0 comments

Comments

@kngroo
Copy link

kngroo commented Dec 7, 2016

The link attribute of the default layout object defined in config/layout.js gets overridden in src/containers/AppContainer.js (https://github.com/janoist1/universal-react-redux-starter-kit/blob/master/src/containers/AppContainer.js#L23).

What exactly is the purpose of overriding the original array? Am I correct in thinking that this is undesirably overriding the entire link array and preventing static link elements from being included for use with Helmet?

There are some link tags that are useful for SEO, and it would be nice to be able to configure them with Helmet.

I'm not sure if there is an existing convention in the project for adding static link tags that I may have overlooked, but my makeshift solution was to create a "staticLink" attribute for the default layout object, and concat it to the link array of the copied object used as the prop for Helmet in AppContainer.js.

@kngroo kngroo changed the title Default layout's link array gets overridden Default layout's link attribute gets overridden Dec 7, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant