Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Dark/Light Mode Compatibility #16182

Open
milinddethe15 opened this issue Jan 18, 2025 · 1 comment
Open

Implement Dark/Light Mode Compatibility #16182

milinddethe15 opened this issue Jan 18, 2025 · 1 comment

Comments

@milinddethe15
Copy link
Contributor

Enhance user experience and accessibility by implementing dark/light mode compatibility for the website.

Features:-

  1. Dark Mode Integration

  2. User Preference Persistence

  3. Accessible Toggle

  4. Theme Consistency

  5. Testing and Feedback

@craigbox
Copy link
Contributor

We had a light/dark mode before a redesign in 2020.

I am of the opinion that to have two themes requires you to have consideration for all assets (including images). This work has't happened yet, so we're likely to end up with figures that either render with a light background in dark mode, or are unreadable as they hard-code black text.

With that in mind we never brought dark mode back, and I would think you would need to do a lot of the "testing and feedback" in an evaluation phase 0 before starting this plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants