Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to deal with CI that machines are changing #276

Open
marcosschroh opened this issue Jan 30, 2025 · 0 comments
Open

How to deal with CI that machines are changing #276

marcosschroh opened this issue Jan 30, 2025 · 0 comments

Comments

@marcosschroh
Copy link

Hi,

Thanks for this library. This is not an issue, is more than a question about how to deal when either when a python version changes or a OS machine changes.

We are running during the CI the command pytest tests/test_benchmarks.py --benchmark-compare --benchmark-compare-fail=mean:10% which it compares the result against the previous benchmark, the problem is that sometimes the machines are not the same per PRs, then the command fails due ERROR: --benchmark-compare-fail requires valid --benchmark-compare. Any ideas how to bypass the error as we can not control the machines types during the CI? How the file to compare is selected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant