Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please consider fixing issues detected by repository checker #254

Closed
2 of 3 tasks
ioBroker-Bot opened this issue Jan 19, 2025 · 7 comments
Closed
2 of 3 tasks

Please consider fixing issues detected by repository checker #254

ioBroker-Bot opened this issue Jan 19, 2025 · 7 comments

Comments

@ioBroker-Bot
Copy link

ioBroker-Bot commented Jan 19, 2025

Notification from ioBroker Check and Service Bot

Dear adapter developer,

I'm the ioBroker Check and Service Bot. I'm an automated tool processing routine tasks for the ioBroker infrastructure. I have recently checked the repository for your adapter rpi2 for common errors and appropiate suggestions to keep this adapter up to date.

This check is based on the current head revisions (master / main branch) of the adapter repository

Please see the result of the check below.

ioBroker.rpi2

Downloads Number of Installations (latest) Number of Installations (stable) - Test and Release

ERRORS:

  • ❗ [E055] malformed dependency detected "@tsconfig/node18":^18.2.4 < 19". Please fix at package.json.
  • ❗ [E055] malformed dependency detected "@types/node":^18.19.69 < 19". Please fix at package.json.

WARNINGS:

  • 👀 [W184] "common.singletonHost" detected for non onlyWWW adapter. Is this really desired?

👍 No suggestions found

Please review issues reported and consider fixing them as soon as appropiate.

Errors reported by repository checker should be fixed as soon as possible. Some of them require a new release to be considered as fixed. Please note that errors reported by checker might be considered as blocking point for future updates at stable repository.

Warnings reported by repository checker should be reviewed. While some warnings can be ignored due to good reasons or a dedicated decision of the developer, most warnings should be fixed as soon as appropiate.

You may start a new check or force the creation of a new issue at any time by adding the following comment to this issue:

@iobroker-bot recheck
or
@iobroker-bot recreate

Please note that I (and the server at GitHub) have always plenty of work to do. So it may last up to 30 minutes until you see a reaction. I will drop a comment here as soon as I start processing.

Feel free to contact me (@ioBroker-Bot) if you have any questions or feel that an issue is incorrectly flagged.

And THANKS A LOT for maintaining this adapter from me and all users.
Let's work together for the best user experience.

your
ioBroker Check and Service Bot

@mcm1957 for evidence

Last update at Thu, 06 Feb 2025 23:13:09 GMT based on commit 253ea34
ioBroker.repochecker 3.3.2

@ioBroker-Bot
Copy link
Author

This issue has been updated by ioBroker Check and Service Bot

The following issues have been fixed
[E055] malformed dependency detected "@tsconfig/node18":^18.2.4 < 19". Please fix at package.json.
[E055] malformed dependency detected "@types/node":^18.19.69 < 19". Please fix at package.json.

👍Thanks for fixing the issues.

@Garfonso
Copy link

Garfonso commented Feb 6, 2025

@mcm1957 the "malformed dependency" actually is not malformed. It prevented dependabot to propose type updates. In a perfect world, this test should even be updated to compare the < X to the supported node version and require it. 😄

@mcm1957
Copy link
Member

mcm1957 commented Feb 6, 2025

Thanks for reporting.
Thought this was fixed already (ioBroker/ioBroker.repochecker#360). I will check the next week.

In a perfect world, this test should even be updated to compare the < X to the supported node version and require it.

Not sure what you mean. Please give me an example.

@Garfonso
Copy link

Garfonso commented Feb 7, 2025

in package.json of this adapter (rpi2), I configured the @types/node dependency to be ^18.19.69 < 19. The checker complains about that version requirement. But it is indeed not malformed. And it makes dependabot not create PRs for types > 18. That is a goot thing, as long as the adapter supports node version 18, so the types fit the minimum required node version.

The major version of the @types/node package should always match the minimum node version in package.json. So if node 18 is still ok, the version requirement for @types/node should contain < 18 (or maybe <= 18 is possible, too, not sure).

@mcm1957
Copy link
Member

mcm1957 commented Feb 10, 2025

@ioBroker-Bot recreate

@ioBroker-Bot
Copy link
Author

Thanks for contacting me.
I received your request to recheck this repository and to recreate the checker issue. I will start doing my work soon.
I will close an existing issue and create a new one if any issues are to be reported.

Thanks for spending your time and working at an ioBroker adapter.

your
ioBroker Check and Service Bot

@ioBroker-Bot
Copy link
Author

Issue outdated due to RECREATE request. Follow up issue #263 has been created.
This issue will be closed.

your
ioBroker Check and Service Bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants