Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

package.json - check release script #354

Open
mcm1957 opened this issue Jan 12, 2025 · 2 comments
Open

package.json - check release script #354

mcm1957 opened this issue Jan 12, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@mcm1957
Copy link
Collaborator

mcm1957 commented Jan 12, 2025 •
edited
Loading

Release script definition should not include --all as this disables manual-review plugin

EDIT:
Do not check for --all but for --hardcoded --yes.
@mcm1957 mcm1957 added the enhancement New feature or request label Jan 12, 2025
@oweitman
Copy link
Contributor

wirklich?
Bei mir nicht, es kommt dennoch die review Abfrage mit all done
und es spart ein commit

@mcm1957
Copy link
Collaborator Author

mcm1957 commented Jan 14, 2025

Ja, hast recht.
Ich habe --all mit --yes verwechselt. Ob ein dev --all verwenden will ist zu 100% seine Entscheidung.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oweitman @mcm1957