Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove redundant word in comment #7516

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: remove redundant word in comment #7516

wants to merge 1 commit into from

Conversation

luchenhan
Copy link

@luchenhan luchenhan commented Jan 4, 2025 •
edited
Loading

Summary

remove redundant word in comment

Related Issues / Discussions

QA Instructions

No need.

Merge Plan

Just merge normally

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@github-actions github-actions bot added python PRs that change python files backend PRs that change backend files services PRs that change app services frontend PRs that change frontend files labels Jan 4, 2025
@psychedelicious
Copy link
Collaborator

Please fill out the PR form.

@luchenhan
Copy link
Author

Please fill out the PR form.

Thanks. Done.

psychedelicious
psychedelicious requested changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@psychedelicious psychedelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review.

This PR makes changes to the TS types generated from the OpenAPI schema. That's a no-no - we should only change the root pydantic models that are used to generate the OpenAPI schema, then generate TS types from those.

As a result, the OpenAPI schema and TS types don't match. We have a CI check for this that has failed.

You'll need to update the pydantic models to fix the spelling error, then generate new TS types. Please do not edit schema.ts directly.

@luchenhan
Copy link
Author

Sorry for the late review.

This PR makes changes to the TS types generated from the OpenAPI schema. That's a no-no - we should only change the root pydantic models that are used to generate the OpenAPI schema, then generate TS types from those.

As a result, the OpenAPI schema and TS types don't match. We have a CI check for this that has failed.

You'll need to update the pydantic models to fix the spelling error, then generate new TS types. Please do not edit schema.ts directly.

Thank you for your reply. I have reverted the changes made to schema.ts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psychedelicious psychedelicious psychedelicious requested changes

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

@maryhipp maryhipp Awaiting requested review from maryhipp maryhipp is a code owner

@hipsterusername hipsterusername Awaiting requested review from hipsterusername hipsterusername is a code owner

@lstein lstein Awaiting requested review from lstein lstein is a code owner

@brandonrising brandonrising Awaiting requested review from brandonrising brandonrising is a code owner

@RyanJDick RyanJDick Awaiting requested review from RyanJDick RyanJDick is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
backend PRs that change backend files frontend PRs that change frontend files python PRs that change python files services PRs that change app services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luchenhan @psychedelicious