-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adopt conventional commits and correct semantic versioning #1334
Comments
Thank you @fastlorenzo Interesting discussion indeed. We had it at multiple occasions internally and here are the highlights:
Warm regards |
@ab-smith I totally agree on the squash PR, this is so much easier to read. What I meant with the conventional commits was for the main branch, so for those commits when merged. Agreed for the semver convention for API, but it'd be great to know from the version as well if something was massively changed or removed from the UI (e.g. #1204 was a patch version, but had implications on the UI so should have been at least considered minor if not major as you removed a UI feature). I understand though that you're in a heavy dev phase, so doing so might be difficult for the moment as well. My 2 cents 😉 |
Oh don't get me wrong, I do appreciate your inputs and you taking the time to word them :) For the the #1204 it was a regression due to a refactoring of the component, to space the requirement rendering a bit better, so I don't believe we can take it as an example for a massive/breaking change. I do get the sentiment though on the importance of mentioning the UI changes on the release notes in a better way and that will be the immediate takeaway, in addition to the linear approach with squashes. The release-please is definitely something worth exploring to say the least to compare it to the native release notes generator of GitHub. This is discussion is a good food for thoughts, so thanks again and I'll keep it open to circle back to it in the upcoming weeks. And yes, we have a few big features coming up, but it's never too late or secondary to do better on our practices and communication 🤗 |
Problem statement
It' be great to have a clear view in the changelog on what are bug fixes/patches, new functionalities or breaking changes, and have it reflected in versions.
One good option could be to use https://www.conventionalcommits.org/
Expected behavior
Given a version number MAJOR.MINOR.PATCH, increment the:
MAJOR version when you make incompatible API changes
MINOR version when you add functionality in a backward compatible manner
PATCH version when you make backward compatible bug fixes
https://semver.org/
Mock
N/A
Additional context
N/A
The text was updated successfully, but these errors were encountered: