[XPU][TritonIntelGPUToLLVM] Handle arithmetic reductions of i1 values
#3113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend `i1` values to `i8` before calling SPIR-V arithmetic group reduction built-ins and truncate back to `i1` afterwards. Signed-off-by: victor-eds <[email protected]>
victor-eds
requested review from
sommerlukas,
Stonepia,
whitneywhtsang and
a team
whitneywhtsang
approved these changes
Jan 8, 2025
etiotto
reviewed
Jan 8, 2025
|
I'll go with a different approach not needing to extend and using logical operations. |
|
I found representing as logical operations made more sense as that's what LLVM does for scalar operations and we could generate a bit better code possibly |
whitneywhtsang
approved these changes
Jan 9, 2025
Stonepia
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use logical operations to represent arithmetic reductions of
i1values. Only the SPIR-V builtins being used need to be changed as LLVM will handle the scalar arithmetic operations used.Closes #3109