Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adds mismatch in package_data to resolve ModuleNotFoundError #4669

Merged
merged 4 commits into from
Jan 8, 2025
Merged

fix: Adds mismatch in package_data to resolve ModuleNotFoundError #4669

merged 4 commits into from
Jan 8, 2025

Conversation

Prtm2110
Copy link
Contributor

@Prtm2110 Prtm2110 commented Jan 3, 2025

Fixes: #4655

@Prtm2110
Copy link
Contributor Author

Prtm2110 commented Jan 8, 2025

The failing test is unrelated!

terriko
terriko requested changes Jan 8, 2025
View reviewed changes
mismatch/__init__.py Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
terriko
terriko approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we're ready to merge! We should probably have a test to make sure that nothing breaks this in the future, but I'll file a separate issue for that.

@terriko terriko merged commit a8800da into intel:main Jan 8, 2025
23 checks passed
@Prtm2110 Prtm2110 deleted the mismatch_bug branch January 8, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terriko terriko terriko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: ModuleNotFoundError: No module named 'mismatch'
2 participants
@Prtm2110 @terriko