Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guarantee that the process 'exits' on failure #1

Open
marianopeck opened this issue Mar 17, 2020 · 1 comment
Open

guarantee that the process 'exits' on failure #1

marianopeck opened this issue Mar 17, 2020 · 1 comment

Comments

@marianopeck
Copy link
Collaborator

I've not found a way to guarantee that the process 'exits' on failure. Any walkback inducing error will launch the interactive debugger. I've tried to intercept most prompts and errors such that Jenkins is told of the error, but definitely not all. If nodialog.exe does not 'exit' then Jenkins waits forever for it to finish. The only way to 'fix' this is to login to the desktop running the jenkins slave and answer whatever prompt is being displayed in the VA Smalltalk UI.

@marianopeck
Copy link
Collaborator Author

Another customer suggest doing something like this:

[
"All build process code here"



] on: ExAll	do:
	[:signal | 
		(Notification handles: signal) 
			ifTrue: [signal pass] 
			ifFalse: [
				
				| errorDescription |
				errorDescription := exception description.
				self log: ('Unexpected Error: %1' bindWith: errorDescription).
				MinimalWalkbackDumper new dumpWalkbackDueTo: errorDescription.
				System exit: 9006 withObject: nil
			
			]
	]

Of course, you can adapt what you do with the error (logging, dumping walkback, whatever)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant