Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upload button disabled when default server config is incompatible with client app #10

Open
robes opened this issue Dec 13, 2019 · 2 comments
Assignees

Comments

@robes
Copy link
Contributor

robes commented Dec 13, 2019

  1. install some version of deriva-download app, let's say version 0.8
  2. connect to a couple servers, say staging.foo.org and dev.foo.org, where staging is the first/default
  3. update your upload spec for dev.foo.org, let's say to accept client version >=1.0 and <2.0
  4. next use of deriva-download it asks you update
  5. update your derive-download to 1.0
  6. restart deriva-download
  7. since staging is the first/default, it will immediately tell you you need to downgrade, but since you don't want to do that, hit cancel
  8. the browse button is disabled
  9. select dev.foo.org from the downdown
  10. login
  11. the browse button remains disabled
@robes
Copy link
Contributor Author

robes commented Dec 13, 2019

I meant to add above that I am not blocked. I simply deleted the offending default spec and restarted the app.

Also, I have a couple thoughts:

  1. it might be worthwhile just letting the user attempt to use the spec if they chose rather than disabling the client. After a "use at your own risk" warning?
  2. at a minimum, it would be really good to allow the user to fetch the latest upload configuration. For instance, in this case, the revised config would allow my 1.0 client to work.
  3. or I suppose is there really an advantage over just deleting the offending config file and re-adding the server. Not sure.

@robes robes transferred this issue from informatics-isi-edu/deriva-client Dec 13, 2019
@robes
Copy link
Contributor Author

robes commented Dec 13, 2019

Well, at a minimum the client should only be disabled for the incompatible configurations, and even then, the client should be able to at least fetch updated configurations (in case it simply needs updating).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants